Vulnerabilities > CVE-2018-14779 - Out-of-bounds Write vulnerability in Yubico PIV Manager, PIV Tool and Smart Card Minidriver

047910
CVSS 6.8 - MEDIUM
Attack vector
PHYSICAL
Attack complexity
LOW
Privileges required
NONE
Confidentiality impact
HIGH
Integrity impact
HIGH
Availability impact
HIGH
low complexity
yubico
CWE-787
nessus

Summary

A buffer overflow issue was discovered in the Yubico-Piv 1.5.0 smartcard driver. The file lib/ykpiv.c contains the following code in the function `ykpiv_transfer_data()`: {% highlight c %} if(*out_len + recv_len - 2 > max_out) { fprintf(stderr, "Output buffer to small, wanted to write %lu, max was %lu.", *out_len + recv_len - 2, max_out); } if(out_data) { memcpy(out_data, data, recv_len - 2); out_data += recv_len - 2; *out_len += recv_len - 2; } {% endhighlight %} -- it is clearly checked whether the buffer is big enough to hold the data copied using `memcpy()`, but no error handling happens to avoid the `memcpy()` in such cases. This code path can be triggered with malicious data coming from a smartcard.

Common Weakness Enumeration (CWE)

Nessus

  • NASL familySuSE Local Security Checks
    NASL idOPENSUSE-2019-1341.NASL
    descriptionThis update for yubico-piv-tool fixes the following issues : Security issues fixed : - Fixed an buffer overflow and an out of bounds memory read in ykpiv_transfer_data(), which could be triggered by a malicious token. (CVE-2018-14779, bsc#1104809, YSA-2018-03) - Fixed an buffer overflow and an out of bounds memory read in _ykpiv_fetch_object(), which could be triggered by a malicious token. (CVE-2018-14780, bsc#1104811, YSA-2018-03) This update was imported from the SUSE:SLE-15:Update update project.
    last seen2020-06-01
    modified2020-06-02
    plugin id124706
    published2019-05-09
    reporterThis script is Copyright (C) 2019-2020 and is owned by Tenable, Inc. or an Affiliate thereof.
    sourcehttps://www.tenable.com/plugins/nessus/124706
    titleopenSUSE Security Update : yubico-piv-tool (openSUSE-2019-1341)
    code
    #
    # (C) Tenable Network Security, Inc.
    #
    # The descriptive text and package checks in this plugin were
    # extracted from openSUSE Security Update openSUSE-2019-1341.
    #
    # The text description of this plugin is (C) SUSE LLC.
    #
    
    include("compat.inc");
    
    if (description)
    {
      script_id(124706);
      script_version("1.2");
      script_cvs_date("Date: 2020/01/21");
    
      script_cve_id("CVE-2018-14779", "CVE-2018-14780");
    
      script_name(english:"openSUSE Security Update : yubico-piv-tool (openSUSE-2019-1341)");
      script_summary(english:"Check for the openSUSE-2019-1341 patch");
    
      script_set_attribute(
        attribute:"synopsis", 
        value:"The remote openSUSE host is missing a security update."
      );
      script_set_attribute(
        attribute:"description", 
        value:
    "This update for yubico-piv-tool fixes the following issues :
    
    Security issues fixed :
    
      - Fixed an buffer overflow and an out of bounds memory
        read in ykpiv_transfer_data(), which could be triggered
        by a malicious token. (CVE-2018-14779, bsc#1104809,
        YSA-2018-03)
    
      - Fixed an buffer overflow and an out of bounds memory
        read in _ykpiv_fetch_object(), which could be triggered
        by a malicious token. (CVE-2018-14780, bsc#1104811,
        YSA-2018-03)
    
    This update was imported from the SUSE:SLE-15:Update update project."
      );
      script_set_attribute(
        attribute:"see_also",
        value:"https://bugzilla.opensuse.org/show_bug.cgi?id=1104809"
      );
      script_set_attribute(
        attribute:"see_also",
        value:"https://bugzilla.opensuse.org/show_bug.cgi?id=1104811"
      );
      script_set_attribute(
        attribute:"solution", 
        value:"Update the affected yubico-piv-tool packages."
      );
      script_set_cvss_base_vector("CVSS2#AV:L/AC:L/Au:N/C:C/I:C/A:C");
      script_set_cvss_temporal_vector("CVSS2#E:U/RL:OF/RC:C");
      script_set_cvss3_base_vector("CVSS:3.0/AV:P/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H");
      script_set_cvss3_temporal_vector("CVSS:3.0/E:U/RL:O/RC:C");
      script_set_attribute(attribute:"exploitability_ease", value:"No known exploits are available");
    
      script_set_attribute(attribute:"plugin_type", value:"local");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:libykcs11-1");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:libykcs11-1-debuginfo");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:libykcs11-devel");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:libykpiv-devel");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:libykpiv1");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:libykpiv1-debuginfo");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:yubico-piv-tool");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:yubico-piv-tool-debuginfo");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:opensuse:yubico-piv-tool-debugsource");
      script_set_attribute(attribute:"cpe", value:"cpe:/o:novell:opensuse:15.0");
    
      script_set_attribute(attribute:"vuln_publication_date", value:"2018/08/15");
      script_set_attribute(attribute:"patch_publication_date", value:"2019/05/08");
      script_set_attribute(attribute:"plugin_publication_date", value:"2019/05/09");
      script_set_attribute(attribute:"generated_plugin", value:"current");
      script_end_attributes();
    
      script_category(ACT_GATHER_INFO);
      script_copyright(english:"This script is Copyright (C) 2019-2020 and is owned by Tenable, Inc. or an Affiliate thereof.");
      script_family(english:"SuSE Local Security Checks");
    
      script_dependencies("ssh_get_info.nasl");
      script_require_keys("Host/local_checks_enabled", "Host/SuSE/release", "Host/SuSE/rpm-list", "Host/cpu");
    
      exit(0);
    }
    
    
    include("audit.inc");
    include("global_settings.inc");
    include("rpm.inc");
    
    if (!get_kb_item("Host/local_checks_enabled")) audit(AUDIT_LOCAL_CHECKS_NOT_ENABLED);
    release = get_kb_item("Host/SuSE/release");
    if (isnull(release) || release =~ "^(SLED|SLES)") audit(AUDIT_OS_NOT, "openSUSE");
    if (release !~ "^(SUSE15\.0)$") audit(AUDIT_OS_RELEASE_NOT, "openSUSE", "15.0", release);
    if (!get_kb_item("Host/SuSE/rpm-list")) audit(AUDIT_PACKAGE_LIST_MISSING);
    
    ourarch = get_kb_item("Host/cpu");
    if (!ourarch) audit(AUDIT_UNKNOWN_ARCH);
    if (ourarch !~ "^(x86_64)$") audit(AUDIT_ARCH_NOT, "x86_64", ourarch);
    
    flag = 0;
    
    if ( rpm_check(release:"SUSE15.0", reference:"libykcs11-1-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"libykcs11-1-debuginfo-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"libykcs11-devel-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"libykpiv-devel-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"libykpiv1-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"libykpiv1-debuginfo-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"yubico-piv-tool-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"yubico-piv-tool-debuginfo-1.5.0-lp150.2.3.1") ) flag++;
    if ( rpm_check(release:"SUSE15.0", reference:"yubico-piv-tool-debugsource-1.5.0-lp150.2.3.1") ) flag++;
    
    if (flag)
    {
      if (report_verbosity > 0) security_hole(port:0, extra:rpm_report_get());
      else security_hole(0);
      exit(0);
    }
    else
    {
      tested = pkg_tests_get();
      if (tested) audit(AUDIT_PACKAGE_NOT_AFFECTED, tested);
      else audit(AUDIT_PACKAGE_NOT_INSTALLED, "libykcs11-1 / libykcs11-1-debuginfo / libykcs11-devel / etc");
    }
    
  • NASL familySuSE Local Security Checks
    NASL idSUSE_SU-2019-1123-1.NASL
    descriptionThis update for yubico-piv-tool fixes the following issues : Security issues fixed : Fixed an buffer overflow and an out of bounds memory read in ykpiv_transfer_data(), which could be triggered by a malicious token. (CVE-2018-14779, bsc#1104809, YSA-2018-03) Fixed an buffer overflow and an out of bounds memory read in _ykpiv_fetch_object(), which could be triggered by a malicious token. (CVE-2018-14780, bsc#1104811, YSA-2018-03) Note that Tenable Network Security has extracted the preceding description block directly from the SUSE security advisory. Tenable has attempted to automatically clean and format it as much as possible without introducing additional issues.
    last seen2020-06-01
    modified2020-06-02
    plugin id124455
    published2019-05-01
    reporterThis script is Copyright (C) 2019-2020 and is owned by Tenable, Inc. or an Affiliate thereof.
    sourcehttps://www.tenable.com/plugins/nessus/124455
    titleSUSE SLED15 / SLES15 Security Update : yubico-piv-tool (SUSE-SU-2019:1123-1)
    code
    #
    # (C) Tenable Network Security, Inc.
    #
    # The descriptive text and package checks in this plugin were
    # extracted from SUSE update advisory SUSE-SU-2019:1123-1.
    # The text itself is copyright (C) SUSE.
    #
    
    include("compat.inc");
    
    if (description)
    {
      script_id(124455);
      script_version("1.3");
      script_cvs_date("Date: 2020/01/21");
    
      script_cve_id("CVE-2018-14779", "CVE-2018-14780");
    
      script_name(english:"SUSE SLED15 / SLES15 Security Update : yubico-piv-tool (SUSE-SU-2019:1123-1)");
      script_summary(english:"Checks rpm output for the updated packages.");
    
      script_set_attribute(
        attribute:"synopsis", 
        value:"The remote SUSE host is missing one or more security updates."
      );
      script_set_attribute(
        attribute:"description", 
        value:
    "This update for yubico-piv-tool fixes the following issues :
    
    Security issues fixed :
    
    Fixed an buffer overflow and an out of bounds memory read in
    ykpiv_transfer_data(), which could be triggered by a malicious token.
    (CVE-2018-14779, bsc#1104809, YSA-2018-03)
    
    Fixed an buffer overflow and an out of bounds memory read in
    _ykpiv_fetch_object(), which could be triggered by a malicious token.
    (CVE-2018-14780, bsc#1104811, YSA-2018-03)
    
    Note that Tenable Network Security has extracted the preceding
    description block directly from the SUSE security advisory. Tenable
    has attempted to automatically clean and format it as much as possible
    without introducing additional issues."
      );
      script_set_attribute(
        attribute:"see_also",
        value:"https://bugzilla.suse.com/show_bug.cgi?id=1104809"
      );
      script_set_attribute(
        attribute:"see_also",
        value:"https://bugzilla.suse.com/show_bug.cgi?id=1104811"
      );
      script_set_attribute(
        attribute:"see_also",
        value:"https://www.suse.com/security/cve/CVE-2018-14779/"
      );
      script_set_attribute(
        attribute:"see_also",
        value:"https://www.suse.com/security/cve/CVE-2018-14780/"
      );
      # https://www.suse.com/support/update/announcement/2019/suse-su-20191123-1/
      script_set_attribute(
        attribute:"see_also",
        value:"http://www.nessus.org/u?db7bfc61"
      );
      script_set_attribute(
        attribute:"solution", 
        value:
    "To install this SUSE Security Update use the SUSE recommended
    installation methods like YaST online_update or 'zypper patch'.
    
    Alternatively you can run the command listed for your product :
    
    SUSE Linux Enterprise Module for Basesystem 15:zypper in -t patch
    SUSE-SLE-Module-Basesystem-15-2019-1123=1"
      );
      script_set_cvss_base_vector("CVSS2#AV:L/AC:L/Au:N/C:C/I:C/A:C");
      script_set_cvss_temporal_vector("CVSS2#E:U/RL:OF/RC:C");
      script_set_cvss3_base_vector("CVSS:3.0/AV:P/AC:L/PR:N/UI:N/S:U/C:H/I:H/A:H");
      script_set_cvss3_temporal_vector("CVSS:3.0/E:U/RL:O/RC:C");
      script_set_attribute(attribute:"exploitability_ease", value:"No known exploits are available");
    
      script_set_attribute(attribute:"plugin_type", value:"local");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:libykcs11");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:libykcs11-1-debuginfo");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:libykcs11-devel");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:libykpiv-devel");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:libykpiv1");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:libykpiv1-debuginfo");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:yubico-piv-tool");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:yubico-piv-tool-debuginfo");
      script_set_attribute(attribute:"cpe", value:"p-cpe:/a:novell:suse_linux:yubico-piv-tool-debugsource");
      script_set_attribute(attribute:"cpe", value:"cpe:/o:novell:suse_linux:15");
    
      script_set_attribute(attribute:"vuln_publication_date", value:"2018/08/15");
      script_set_attribute(attribute:"patch_publication_date", value:"2019/04/30");
      script_set_attribute(attribute:"plugin_publication_date", value:"2019/05/01");
      script_set_attribute(attribute:"generated_plugin", value:"current");
      script_end_attributes();
    
      script_category(ACT_GATHER_INFO);
      script_copyright(english:"This script is Copyright (C) 2019-2020 and is owned by Tenable, Inc. or an Affiliate thereof.");
      script_family(english:"SuSE Local Security Checks");
    
      script_dependencies("ssh_get_info.nasl");
      script_require_keys("Host/local_checks_enabled", "Host/cpu", "Host/SuSE/release", "Host/SuSE/rpm-list");
    
      exit(0);
    }
    
    
    include("audit.inc");
    include("global_settings.inc");
    include("rpm.inc");
    
    
    if (!get_kb_item("Host/local_checks_enabled")) audit(AUDIT_LOCAL_CHECKS_NOT_ENABLED);
    release = get_kb_item("Host/SuSE/release");
    if (isnull(release) || release !~ "^(SLED|SLES)") audit(AUDIT_OS_NOT, "SUSE");
    os_ver = pregmatch(pattern: "^(SLE(S|D)\d+)", string:release);
    if (isnull(os_ver)) audit(AUDIT_UNKNOWN_APP_VER, "SUSE");
    os_ver = os_ver[1];
    if (! preg(pattern:"^(SLED15|SLES15)$", string:os_ver)) audit(AUDIT_OS_NOT, "SUSE SLED15 / SLES15", "SUSE " + os_ver);
    
    if (!get_kb_item("Host/SuSE/rpm-list")) audit(AUDIT_PACKAGE_LIST_MISSING);
    
    cpu = get_kb_item("Host/cpu");
    if (isnull(cpu)) audit(AUDIT_UNKNOWN_ARCH);
    if (cpu !~ "^i[3-6]86$" && "x86_64" >!< cpu && "s390x" >!< cpu) audit(AUDIT_LOCAL_CHECKS_NOT_IMPLEMENTED, "SUSE " + os_ver, cpu);
    
    sp = get_kb_item("Host/SuSE/patchlevel");
    if (isnull(sp)) sp = "0";
    if (os_ver == "SLES15" && (! preg(pattern:"^(0)$", string:sp))) audit(AUDIT_OS_NOT, "SLES15 SP0", os_ver + " SP" + sp);
    if (os_ver == "SLED15" && (! preg(pattern:"^(0)$", string:sp))) audit(AUDIT_OS_NOT, "SLED15 SP0", os_ver + " SP" + sp);
    
    
    flag = 0;
    if (rpm_check(release:"SLES15", sp:"0", reference:"libykcs11-1-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"libykcs11-1-debuginfo-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"libykcs11-devel-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"libykpiv-devel-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"libykpiv1-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"libykpiv1-debuginfo-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"yubico-piv-tool-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"yubico-piv-tool-debuginfo-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLES15", sp:"0", reference:"yubico-piv-tool-debugsource-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"libykcs11-1-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"libykcs11-1-debuginfo-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"libykcs11-devel-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"libykpiv-devel-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"libykpiv1-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"libykpiv1-debuginfo-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"yubico-piv-tool-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"yubico-piv-tool-debuginfo-1.5.0-3.3.33")) flag++;
    if (rpm_check(release:"SLED15", sp:"0", reference:"yubico-piv-tool-debugsource-1.5.0-3.3.33")) flag++;
    
    
    if (flag)
    {
      if (report_verbosity > 0) security_hole(port:0, extra:rpm_report_get());
      else security_hole(0);
      exit(0);
    }
    else
    {
      tested = pkg_tests_get();
      if (tested) audit(AUDIT_PACKAGE_NOT_AFFECTED, tested);
      else audit(AUDIT_PACKAGE_NOT_INSTALLED, "yubico-piv-tool");
    }
    
  • NASL familySuSE Local Security Checks
    NASL idOPENSUSE-2018-969.NASL
    descriptionThis update for yubico-piv-tool fixes the following issues : Security issues fixed : - CVE-2018-14779: Fixed an buffer overflow and an out of bounds memory read in ykpiv_transfer_data(), which could be triggered by a malicious token. (boo#1104809, YSA-2018-03) - CVE-2018-14780: Fixed an buffer overflow and an out of bounds memory read in _ykpiv_fetch_object(), which could be triggered by a malicious token. (boo#1104811, YSA-2018-03)
    last seen2020-06-05
    modified2018-09-06
    plugin id117329
    published2018-09-06
    reporterThis script is Copyright (C) 2018-2020 and is owned by Tenable, Inc. or an Affiliate thereof.
    sourcehttps://www.tenable.com/plugins/nessus/117329
    titleopenSUSE Security Update : yubico-piv-tool (openSUSE-2018-969)
  • NASL familyUbuntu Local Security Checks
    NASL idUBUNTU_USN-4276-1.NASL
    descriptionIt was discovered that libykpiv, a supporting library of the Yubico PIV Tool and YubiKey PIV Manager, mishandled specially crafted input. An attacker with a custom-made, malicious USB device could potentially execute arbitrary code on a computer running the Yubico PIV Tool or Yubikey PIV Manager. Note that Tenable Network Security has extracted the preceding description block directly from the Ubuntu security advisory. Tenable has attempted to automatically clean and format it as much as possible without introducing additional issues.
    last seen2020-06-01
    modified2020-06-02
    plugin id133648
    published2020-02-12
    reporterUbuntu Security Notice (C) 2020 Canonical, Inc. / NASL script (C) 2020 and is owned by Tenable, Inc. or an Affiliate thereof.
    sourcehttps://www.tenable.com/plugins/nessus/133648
    titleUbuntu 18.04 LTS : Yubico PIV Tool vulnerabilities (USN-4276-1)