Vulnerabilities > CVE-2017-12426 - Improper Input Validation vulnerability in Gitlab

#
# (C) Tenable Network Security, Inc.
#
# The descriptive text and package checks in this plugin were  
# extracted from the FreeBSD VuXML database :
#
# Copyright 2003-2018 Jacques Vidrine and contributors
#
# Redistribution and use in source (VuXML) and 'compiled' forms (SGML,
# HTML, PDF, PostScript, RTF and so forth) with or without modification,
# are permitted provided that the following conditions are met:
# 1. Redistributions of source code (VuXML) must retain the above
#    copyright notice, this list of conditions and the following
#    disclaimer as the first lines of this file unmodified.
# 2. Redistributions in compiled form (transformed to other DTDs,
#    published online in any format, converted to PDF, PostScript,
#    RTF and other formats) must reproduce the above copyright
#    notice, this list of conditions and the following disclaimer
#    in the documentation and/or other materials provided with the
#    distribution.
# 
# THIS DOCUMENTATION IS PROVIDED BY THE AUTHOR AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
# THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
# PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR OR CONTRIBUTORS
# BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
# OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT
# OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR
# BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
# WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE
# OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS DOCUMENTATION,
# EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
#

include("compat.inc");

if (description)
{
  script_id(102467);
  script_version("3.4");
  script_cvs_date("Date: 2018/11/10 11:49:46");

  script_cve_id("CVE-2017-12426");

  script_name(english:"FreeBSD : GitLab -- two vulnerabilities (abcc5ad3-7e6a-11e7-93f7-d43d7e971a1b)");
  script_summary(english:"Checks for updated packages in pkg_info output");

  script_set_attribute(
    attribute:"synopsis", 
    value:
"The remote FreeBSD host is missing one or more security-related
updates."
  );
  script_set_attribute(
    attribute:"description", 
    value:
"GitLab reports : Remote Command Execution in git client An external
code review performed by Recurity-Labs identified a remote command
execution vulnerability in git that could be exploited via the 'Repo
by URL' import option in GitLab. The command line git client was not
properly escaping command line arguments in URLs using the SSH
protocol before invoking the SSH client. A specially crafted URL could
be used to execute arbitrary shell commands on the GitLab server. To
fully patch this vulnerability two fixes were needed. The Omnibus
versions of GitLab contain a patched git client. For source users who
may still be running an older version of git, GitLab now also blocks
import URLs containing invalid host and usernames. This issue has been
assigned CVE-2017-12426. Improper sanitization of GitLab export files
on import GitLab versions 8.13.3, 8.12.8, 8.11.10, 8.10.13, and 8.9.12
contained a patch for a critical directory traversal vulnerability in
the GitLab export feature that could be exploited by including
symlinks in the export file and then re-importing it to a GitLab
instance. This vulnerability was patched by checking for and removing
symlinks in these files on import. Recurity-Labs also determined that
this fix did not properly remove symlinks for hidden files. Though not
as dangerous as the original vulnerability hidden file symlinks could
still be used to steal copies of git repositories belonging to other
users if the path to the git repository was known by the attacker. An
updated fix has been included in these releases that properly removes
all symlinks. This import option was not made available to non-admin
users until GitLab 8.13.0."
  );
  script_set_attribute(
    attribute:"see_also",
    value:"https://about.gitlab.com/2017/08/10/gitlab-9-dot-4-dot-4-released/"
  );
  # https://vuxml.freebsd.org/freebsd/abcc5ad3-7e6a-11e7-93f7-d43d7e971a1b.html
  script_set_attribute(
    attribute:"see_also",
    value:"http://www.nessus.org/u?68cc630f"
  );
  script_set_attribute(attribute:"solution", value:"Update the affected packages.");
  script_set_cvss_base_vector("CVSS2#AV:N/AC:M/Au:N/C:P/I:P/A:P");
  script_set_cvss3_base_vector("CVSS:3.0/AV:N/AC:L/PR:N/UI:R/S:U/C:H/I:H/A:H");

  script_set_attribute(attribute:"plugin_type", value:"local");
  script_set_attribute(attribute:"cpe", value:"p-cpe:/a:freebsd:freebsd:gitlab");
  script_set_attribute(attribute:"cpe", value:"cpe:/o:freebsd:freebsd");

  script_set_attribute(attribute:"vuln_publication_date", value:"2017/08/10");
  script_set_attribute(attribute:"patch_publication_date", value:"2017/08/11");
  script_set_attribute(attribute:"plugin_publication_date", value:"2017/08/14");
  script_end_attributes();

  script_category(ACT_GATHER_INFO);
  script_copyright(english:"This script is Copyright (C) 2017-2018 and is owned by Tenable, Inc. or an Affiliate thereof.");
  script_family(english:"FreeBSD Local Security Checks");

  script_dependencies("ssh_get_info.nasl");
  script_require_keys("Host/local_checks_enabled", "Host/FreeBSD/release", "Host/FreeBSD/pkg_info");

  exit(0);
}


include("audit.inc");
include("freebsd_package.inc");


if (!get_kb_item("Host/local_checks_enabled")) audit(AUDIT_LOCAL_CHECKS_NOT_ENABLED);
if (!get_kb_item("Host/FreeBSD/release")) audit(AUDIT_OS_NOT, "FreeBSD");
if (!get_kb_item("Host/FreeBSD/pkg_info")) audit(AUDIT_PACKAGE_LIST_MISSING);


flag = 0;

if (pkg_test(save_report:TRUE, pkg:"gitlab>=7.9.0<=8.17.8")) flag++;
if (pkg_test(save_report:TRUE, pkg:"gitlab>=9.0.0<=9.0.12")) flag++;
if (pkg_test(save_report:TRUE, pkg:"gitlab>=9.1.0<=9.1.9")) flag++;
if (pkg_test(save_report:TRUE, pkg:"gitlab>=9.2.0<=9.2.9")) flag++;
if (pkg_test(save_report:TRUE, pkg:"gitlab>=9.3.0<=9.3.9")) flag++;
if (pkg_test(save_report:TRUE, pkg:"gitlab>=9.4.0<=9.4.3")) flag++;

if (flag)
{
  if (report_verbosity > 0) security_warning(port:0, extra:pkg_report_get());
  else security_warning(0);
  exit(0);
}
else audit(AUDIT_HOST_NOT, "affected");